Java8ExtendedSSLSession getRequestedServerNames returns null instead of empty list

[dbardbar]

Java8ExtendedSSLSession getRequestedServerNames returns null instead of empty list, in case the delegate returns null.
According to the documentation in ExtendedSSLSession, this method should return a non-null list.

This causes a null pointer exception in sun.security.ssl.X509TrustManagerImpl, causing the handshake to fail.

[dbardbar]

I created a PR for this, but I'm not sure how to link it to this issue.
Help would be appreciated...

[prbprbprb]

Ouch, thanks!

And thanks for the PR - Github will automagically link it to the issue if you reference it in the commit message, e.g. #977

[dbardbar]

@prbprbprb, I didn't put it in the commit message. Should I delete the existing PR, and create a new commit with a new commit message?

Also, having problems with Google's CLA. I hope I'll get it solved...

[prbprbprb]

I took the liberty of editing it into your PR (you can do it via the web UI)... Also added a note about what I think is the issue with the CLA.

[dbardbar]

@prbprbprb, thanks for all your help!
I messed up - my commit was done using my corporate email..
I tried 'git ammend', but there's still the original commit in the history, which is probably not OK with the CLA bot.
Should I just start the PR from scratch, to make everyone's life easier?

[prbprbprb]

If you don't mind, I think that would be the best course. Sorry for all the hassle for a short PR!

[dbardbar]

@prbprbprb, CLA appeased. :-)

What is you general release strategy? When can I expect to see a new release with this fix?

[prbprbprb]

We're actually overdue a bugfix release to fix two other issues, so I'll bundle this as well and it should go out this week.