Skip to content

Conversation

@politician
Copy link
Contributor

Since the upgrade to OpenJDK 11 and the latest bazel, the Dockerfile is broken.
This pull request fixes it and ensures greater futureproofness by using the same script as GCB

@politician
Copy link
Contributor Author

@mikelalcon @hsudhof I have signed the CLA, you can re-scan it

@politician
Copy link
Contributor Author

@hsudhof Any chance you can merge this PR?

I build a Docker image for https://github.com/olivr/copybara-action and I'd rather use the Dockerfile from this repo than maintain my own Dockerfile.
Besides I am sure others will benefit from a working Dockerfile.

Thank you

@gjasny
Copy link
Contributor

gjasny commented Feb 4, 2022

Is there a reason why you removed buildozer and buildifier from the image?

@politician
Copy link
Contributor Author

I believe there was no reason for them to be in here in the first place?
They could be re-added but I think the less extraneous dependencies the better.

@gjasny
Copy link
Contributor

gjasny commented Feb 5, 2022

Some copybara rules depend on those two binaries. When I run copybara from the docker image I'd have to provide them via some file or container mapping. This could get more complicated than necessary.

If there are no technical reasons to exclude them I'd prefer keeping them in the image.

@politician
Copy link
Contributor Author

@gjasny Indeed they are even at the beginning of the docs 🙊
I've just added them back. Please let me know if you see anything else.

@mikelalcon
Copy link
Collaborator

Hi! sorry for the delay. I think the change looks good in general, just one question about jdk.

@hsudhof hsudhof self-assigned this Apr 12, 2022
@qqaatw
Copy link

qqaatw commented Aug 2, 2022

Hi, is there any update?

Thanks for the fix, BTW.

@copybara-staging copybara-staging bot closed this in 3b0e0e6 Aug 2, 2022
@mikelalcon
Copy link
Collaborator

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants