-
Notifications
You must be signed in to change notification settings - Fork 297
Fix Docker build to match Google Cloud Build script #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mikelalcon @hsudhof I have signed the CLA, you can re-scan it |
|
@hsudhof Any chance you can merge this PR? I build a Docker image for https://github.com/olivr/copybara-action and I'd rather use the Dockerfile from this repo than maintain my own Dockerfile. Thank you |
|
Is there a reason why you removed buildozer and buildifier from the image? |
|
I believe there was no reason for them to be in here in the first place? |
|
Some copybara rules depend on those two binaries. When I run copybara from the docker image I'd have to provide them via some file or container mapping. This could get more complicated than necessary. If there are no technical reasons to exclude them I'd prefer keeping them in the image. |
Signed-off-by: Romain Barissat <romain-noreply@barissat.com>
|
@gjasny Indeed they are even at the beginning of the docs 🙊 |
|
Hi! sorry for the delay. I think the change looks good in general, just one question about jdk. |
|
Hi, is there any update? Thanks for the fix, BTW. |
|
Merged |
Since the upgrade to OpenJDK 11 and the latest bazel, the Dockerfile is broken.
This pull request fixes it and ensures greater futureproofness by using the same script as GCB