Implemented Replace Matches Functional Operator#114
Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom May 28, 2025
Merged
Implemented Replace Matches Functional Operator#114copybara-service[bot] merged 2 commits intogoogle:mainfrom
copybara-service[bot] merged 2 commits intogoogle:mainfrom
Conversation
evan-gordon
approved these changes
May 2, 2025
Collaborator
evan-gordon
left a comment
evan-gordon
left a comment
There was a problem hiding this comment.
Overall looks good so I'll approve! Mind fixing the formatting changes though?
bodiebice
force-pushed
the
ReplaceMatches
branch
3 times, most recently
from
e008010 to
b094b8e
Compare
Contributor
Author
|
@evan-gordon I think I was able to fix all of the visual issues. Going to look into seeing if linter settings are causing issues |
Contributor
Author
|
@evan-gordon Should have updated and fixed failing xml test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the Replace Matches functional operator.