ci: declare GITHUB_TOKEN permissions on cargo and nightly workflows#1020
Merged
copybara-service[bot] merged 1 commit intoMay 28, 2026
Merged
Conversation
nightly.yaml is a stub that just echoes a redirect message and exits 1 (the
real workflow lives on the test-matrix branch). It doesn't need any
GITHUB_TOKEN scope, so permissions: {}.
rust.yml runs cargo test + cargo build + cmake test on every push/PR. Two
jobs, both pure CI - contents: read is enough.
The mdbook.yaml workflow already declares explicit permissions for the
GitHub Pages deployment; this aligns the remaining cargo + nightly
workflows with that pattern.
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
1a961bb to
975e131
Compare
Contributor
Author
|
Hello, Checking in on review timing. Glad to rebase whenever convenient. Appreciated. |
Contributor
|
Whoops sorry thank you for the ping (and the PR!). I will get this merged. |
copybara-service Bot
pushed a commit
that referenced
this pull request
May 28, 2026
-- 975e131 by Arpit Jain <arpitjain099@gmail.com>: ci: add explicit GITHUB_TOKEN permissions to nightly and cargo workflows nightly.yaml is a stub that just echoes a redirect message and exits 1 (the real workflow lives on the test-matrix branch). It doesn't need any GITHUB_TOKEN scope, so permissions: {}. rust.yml runs cargo test + cargo build + cmake test on every push/PR. Two jobs, both pure CI - contents: read is enough. The mdbook.yaml workflow already declares explicit permissions for the GitHub Pages deployment; this aligns the remaining cargo + nightly workflows with that pattern. Signed-off-by: Arpit Jain <arpitjain099@gmail.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#1020 from arpitjain099:ci/add-permissions 975e131 PiperOrigin-RevId: 921709603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflows currently leave
GITHUB_TOKENscope implicit:nightly.yaml— stub that just echoes a redirect message andexit 1s. No checkout, no install, no API.permissions: {}(deny all) is correct here.rust.yml— two jobs (test,test_cmake) runningcargo test/cargo build/cmake build && ctest. Pure CI;contents: readat the workflow level covers theactions/checkoutstep and the cache restore. Nothing here pushes commits or calls write APIs.mdbook.yamlalready declares explicit permissions for the GH Pages deployment; this just brings the other two in line.