Crubit fails with "unknown attribute" error when encountering [[clang::coro_wrapper]] on functions.#941
Merged
copybara-service[bot] merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_909988829
branch
from
5338cee to
a9d613c
Compare
…::coro_wrapper]] on functions. This attribute is a static analysis hint and does not affect the ABI or type layout. We verified that all 7 Clang coroutine attributes are safe to ignore regarding ABI. This CL centralizes the ignoring of these attributes in CollectUnknownAttrs in ast_util.cc. It also cleans up cxx_record.cc to remove redundant checks. A regression test is added to verify the fix. PiperOrigin-RevId: 910550138
copybara-service
Bot
force-pushed
the
test_909988829
branch
from
a9d613c to
6840510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crubit fails with "unknown attribute" error when encountering [[clang::coro_wrapper]] on functions.
This attribute is a static analysis hint and does not affect the ABI or type layout.
We verified that all 7 Clang coroutine attributes are safe to ignore regarding ABI.
This CL centralizes the ignoring of these attributes in CollectUnknownAttrs in ast_util.cc.
It also cleans up cxx_record.cc to remove redundant checks.
A regression test is added to verify the fix.