RuntimeException

[jkstop]

I got an exception in some devices running on Android 6.0.
Every activity extends BaseActivity which onCreate method calls AndroidInjection.inject(this) method before super.onCreate().
First activity calling throw exception:

Caused by: java.lang.RuntimeException:
at dagger.android.AndroidInjection.inject (AndroidInjection.java:48)

My app class implements HasActivityInjector interface.

[ronshapiro]

This appears to be a question - please use StackOverflow with the dagger-2 tag instead, as that is a better forum for questions.

[peterkuterna]

@jkstop Did you find the reason for the RuntimeException on Android 6.0 devices? We are seeing the same issue, only happening on Android 6.0 devices.

[jkstop]

No, I didn't find the reason. It,s a real bug

[peterkuterna]

@jkstop You see probably the same stack track in de Play Developer Console? And only for 6.0?
java.lang.RuntimeException:
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3255)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3351)
at android.app.ActivityThread.access$1100 (ActivityThread.java:222)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1796)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:158)
at android.app.ActivityThread.main (ActivityThread.java:7230)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1120)
Caused by: java.lang.RuntimeException:
at dagger.android.AndroidInjection.inject (AndroidInjection.java:48)
at dagger.android.support.DaggerAppCompatActivity.onCreate (DaggerAppCompatActivity.java:42)
at .SplashActivity.onCreate (SplashActivity.kt:24)
at android.app.Activity.performCreate (Activity.java:6877)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1136)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3208)

[jkstop]

Yes, same stack and only 6.0. My app has 20000 active users per week and this bug got near 100 users. Problem in new injector from dagger 2.11 version. Previous version is ok. Try open an issue, maybe you will be more lucky

[peterkuterna]

@ronshapiro Can this issue be re-openend?

We are using dagger-android 2.11 for our newly released app.

Info of our app setup:

• our App extends DaggerApplication
• our AndroidManifest.xml specifies our App class as application entry
• our activitities are extending DaggerAppCompatActivity
• we are not using multidex
• the crash only seems to be happening on a wide range of devices, only running Android 6.0
• was not able to reproduce it on a Nexus 5 with the 6.0.0 factory image flashed onto it

[jkstop]

Simular issue with same settings:

• App does not extends DaggerApplication, it's implement interface HasActivityInjector
• App has multidex support

[ronshapiro]

This is more likely to be an OEM issue than a Dagger one if it's only failing on some devices.

[peterkuterna]

Then this is a widespread OEM issue. The list of devices on which 2 of those stack traces are occurring:

Galaxy A5 (a5ulte) 59 7.0%
LG G4 (p1) 55 6.6%
OnePlus2 (OnePlus2) 45 5.4%
X (OnePlus) 38 4.5%
Liquid Zest 4G (acer_t07) 32 3.8%
Galaxy S5 mini (kminilte) 31 3.7%
Galaxy A3 (a3ulte) 31 3.7%
E5504 (B5530) 27 3.2%
Galaxy Tab A 9.7 (gt510wifi) 26 3.1%
Galaxy S5 (klte) 25 3.0%
Galaxy J7(2016) (j7xelte) 23 2.7%
Cat S60 (CatS60) 23 2.7%
Galaxy Note4 (trlte) 22 2.6%
Galaxy S7 (herolte) 20 2.4%
Galaxy Xcover3 (xcover3velte) 17 2.0%
P8 Lite (hwALE-H) 17 2.0%
Galaxy J5(2016) (j5xnlte) 15 1.8%
Galaxy J5 (j5nlte) 15 1.8%
One (M8) (htc_m8) 15 1.8%
Liquid Zest Plus (acer_t08) 15 1.8%
Others 286 34.2%

LENNY3 (V3702AN) 56 10.7%
One (A0001) 53 10.2%
U FEEL LITE (P4601AN) 9 7.5%
Moto G4 Play (harpia) 30 5.7%
E5006/P5006 (B5032) 30 5.7%
Xperia E5 (F3311) 27 5.2%
FEVER (l5460) 21 4.0%
Moto G (3rd Gen) (osprey_umts) 20 3.8%
Moto G (3rd Gen) (osprey_u2) 18 3.4%
Nexus 5 (hammerhead) 15 2.9%
Xperia M5 (E5603) 15 2.9%
55 Helium (ac55he) 14 2.7%
Xperia XA (F3111) 13 2.5%
U FEEL (P6601AE) 11 2.1%
L-EMENT 403 (L-EMENT_403) 9 1.7%
JERRY (v2806) 8 1.5%
DROID MAXX 2 (lux) 8 1.5%
Moto E with 4G LTE (2nd Gen) (surnia_umts) 7 1.3%
X1030x (X1030X) 6 1.1%
TAB 2 A10 (A10-70F) 6 1.1%
Others 116 22.2%

[tbroyer]

And yet: the javadoc implies that the application is available when onCreate is called; and if you look at the code:

• in Marshmallow:
  • https://android.googlesource.com/platform/frameworks/base/+/marshmallow-release/core/java/android/app/ActivityThread.java#2350 (and then line 2367)
  • https://android.googlesource.com/platform/frameworks/base/+/marshmallow-release/core/java/android/app/Activity.java#6195 (and line 918)
• in Nougat:
  • https://android.googlesource.com/platform/frameworks/base/+/nougat-release/core/java/android/app/ActivityThread.java#2580 (and then line 2597)
  • https://android.googlesource.com/platform/frameworks/base/+/nougat-release/core/java/android/app/Activity.java#6621 (and line 961)
• in Oreo:
  • https://android.googlesource.com/platform/frameworks/base/+/oreo-release/core/java/android/app/ActivityThread.java#2750 (and then line 2768)
  • https://android.googlesource.com/platform/frameworks/base/+/oreo-release/core/java/android/app/Activity.java#6930 (and line 1015)

Each time, onCreate is called afterattach() has set the application, and onCreate itself calls getApplication() and would blow up if null (you can follow the calls through Instrumentation#callActivityOnCreate and Activity#performCreate, as seen in the stack posted earlier in #891 (comment)).

In theory, there's no way getApplication() could return null from within the activity's onCreate…

(you can trace through
https://android.googlesource.com/platform/frameworks/base/+/oreo-release/core/java/android/app/LoadedApk.java#941 and https://android.googlesource.com/platform/frameworks/base/+/oreo-release/core/java/android/app/Instrumentation.java#1098 that the application passed to Activity#attach cannot be null either)

[pwiniars]

We have the same problem, almost 100% on Android 6 and reported only in Developer Console (not in Crashlytics). Mostly when Firebase PUSH arrives, but in the main activity also. The theory is that it's somehow connected with long live in background (when user press home) and memory management, although we have no evidence. Since 09/2017 this crash occurred 8500 times.

Here is simple app, that demonstrates the dependency injection flow - maybe it's incorrect? https://github.com/pwiniars/InjectionExample

And here's the stacktrace from console on production application:
java.lang.RuntimeException: at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2426) at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:2490) at android.app.ActivityThread.-wrap11 (ActivityThread.java) at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1354) at android.os.Handler.dispatchMessage (Handler.java:102) at android.os.Looper.loop (Looper.java:148) at android.app.ActivityThread.main (ActivityThread.java:5443) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:728) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:618) Caused by: java.lang.RuntimeException: at dagger.android.AndroidInjection.inject (AndroidInjection.java:48) at pl.example.view.BaseActivity.onCreate (BaseActivity.java:94) at pl.example.view.SplashActivity.onCreate (SplashActivity.java:95) at android.app.Activity.performCreate (Activity.java:6245) at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1130) at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2379)

[ChrisKruegerDev]

@ronshapiro Could you reopen this thread? I cannot see a specific OEM issue:
Xperia Z2 (D6503)
Galaxy Note4 (trltevzw)
GX8 (hwRIO-L01)
Mate S (HWCRR)
Y5 2017 (HWMYA-L6737)
LG X power (mk6p55)
Le Max2 (le_x2_na)
LG G3 (g3)
B2017G (msm8952_64)
LG G4 (p1)
Galaxy A7 (a73g)
Galaxy S5 (klteatt)
Zmax Pro (urd)
Galaxy Note4 (trlteatt)
Galaxy S5 (klte)
Galaxy S7 Edge (hero2lte)
5056D (POP455C)
Xperia Z3 Compact (D5803)
Xperia Z2 (D6503)
6055A (idol4)

Did you solved the probelm? I got some hundred crashes, but mostely on services.