Fix Dagger multibinding duplicate tracking for Maps#5167
Merged
Conversation
Currently, Dagger only verifies duplicate map key contributions within the same component. Contributions with duplicate keys across the component hierarchy are ignored, resulting in masked values or runtime crashes when backed by Guava. This change introduces strict duplicate detection across the full map binding graph. Dagger now performs compile-time verification to reject duplicate map keys across the entire component hierarchy. This behavior is controlled by the new compiler option -Adagger.mapMultibindingDuplicateDetectionFix. When enabled, strict duplicate tracking is enforced across the component hierarchy. RELNOTES=Fixed Dagger multibinding duplicate masking across Map components (compile-time validation). PiperOrigin-RevId: 915631609
copybara-service
Bot
force-pushed
the
test_gh-pages_902749242
branch
from
97d129e to
058b079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Dagger multibinding duplicate tracking for Maps
Currently, Dagger only verifies duplicate map key contributions within the same component. Contributions with duplicate keys across the component hierarchy are ignored, resulting in masked values or runtime crashes when backed by Guava.
This change introduces strict duplicate detection across the full map binding graph. Dagger now performs compile-time verification to reject duplicate map keys across the entire component hierarchy.
This behavior is controlled by the new compiler option -Adagger.mapMultibindingDuplicateDetectionFix. When enabled, strict duplicate tracking is enforced across the component hierarchy.
RELNOTES=Fixed Dagger multibinding duplicate masking across Map components (compile-time validation).