Enable warnings as errors in capture_service#699
Merged
footballhead merged 3 commits intogoogle:mainfrom Jan 13, 2026
Merged
Conversation
Force developers to deal with warnings, either by fixing or squelching, to improve code health.
footballhead
commented
Jan 12, 2026
hysw
approved these changes
Jan 12, 2026
GrantComm
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force developers to deal with warnings, either by fixing or squelching, to improve code health.
Use the non-target-specific
add_compile_optionsinstead oftarget_compile_optionssince I want it to should apply by default to all targets