Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@chalin Hi, I'm not sure who needs to approve this workflow. Thank you! |
|
@svrnm If you could please approve this, thank you. |
|
@didiViking best you ask some other Romanian speakers to approve and verify (even if they only provide a LGTM here as a comment), I think that's the most helpful to the docsy maintainers |
|
@dnanuti @IrinaKarantoniou @miaits If I could have your review on the Romanian content, many thanks. |
|
@IrinaKarantoniou Thank you for the review, all has been corrected. Please re-check and leave a LGTM if all is ok. |
|
@didiViking You are very welcome! ❤️ LGTM |
|
@svrnm Good to merge. Thank you. |
I am not the person that is able to help you with that, the docsy maintainers will have to take a look. |
|
@chalin Hi, it seems that you were able to merge your PRs. Could you please approve this one or LMK how I can merge it? Thank you. |
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Hi @didiViking @IrinaKarantoniou - thank you for this contribution. I'll review it as soon as I can when I'm back.
@chalin Any update on this? Many thanks. |
|
@didiViking - could you commit an addition so that you match #2602, which will be landing shortly. That way you won't have to submit another PR. If you prefer submitting another PR, let me know. |
Let me merge and we'll address the addition later. |
4 participants
Related issue: open-telemetry/opentelemetry.io#4593