Check for primitive Objects.hashCode() arguments

[leventov]

It's generally pointless to pass any primitive to Objects.hashCode(). A particularly interesting case is

Objects.hashCode(someObj.hashCode())

[lowasser]

I'm not sure I follow the general case. Why wouldn't you have a class with several primitive fields that you hash with Objects.hashCode?

[leventov]

@lowasser Objects.hashCode(primitive) is always "worse" than Primitive.hashCode(primitive). Don't you confuse Objects.hashCode() and Objects.hash()?

The idea of this issue came from the bug Objects.hashCode(someObj.hashCode()) in my own code, where I meant Objects.hashCode(someObj). I expect that this bug should be relatively widespread.

[lowasser]

Don't you confuse Objects.hashCode() and Objects.hash()?

Yes, I did, my bad.