[2.3.3] RxReturnValueIgnored false-positive

[boris-petrov]

ConcurrentMap<String, Single<String>> map = new ConcurrentHashMap<>();
map.remove("foobar");

The second line will give a RxReturnValueIgnored warning (because remove returns a Single<String>) which is wrong.

P.S. The same applies for put.

[graememorgan]

Wow, that's a curious case. Presumably the same would, in principle, apply to any other ReturnValueIgnored checks.

Have you seen this in practice?

[boris-petrov]

ReturnValueIgnored is actually one of the very few warnings I’ve disabled, because I get lots and lots of false-positives. I could point out some next week if you would like. P.S. Actually I've disabled `FutureReturnValueIgnored`, not `ReturnValueIgnored`.

[ZacSweers]

Maybe remove/put should be implicit @CanIgnoreReturnValue types?