NullAway pattern fails on OpenJDK 27-ea+17

[sormuras]

It worked on OpenJDK 27-ea+16 - find the original issue at junit-team/junit-framework#5605 and the associated build scan at https://ge.junit.org/s/qnhwhk6toc2qc

     error-prone version: 2.48.0
     BugPattern: NullAway
     Stack Trace:
     org.checkerframework.nullaway.javacutil.BugInCF: Problem with initial store for CFGMethod(
  
  @Override
  public JupiterEngineExecutionContext execute(JupiterEngineExecutionContext context, DynamicTestExecutor dynamicTestExecutor) {
      DynamicTestInvocationContext dynamicTestInvocationContext = new DefaultDynamicTestInvocationContext(requiredDynamicTest().getExecutable());
      ExtensionContext extensionContext = context.getExtensionContext();
      ExtensionRegistry extensionRegistry = context.getExtensionRegistry();
      interceptorChain.<@Nullable Void>invoke(toInvocation(), extensionRegistry, InterceptorCall.ofVoid((InvocationInterceptor interceptor, InvocationInterceptor.Invocation<@Nullable Void> wrappedInvocation)->interceptor.interceptDynamicTest(wrappedInvocation, dynamicTestInvocationContext, extensionContext)));
      return context;
  }
  ), parameters=[context, dynamicTestExecutor]
    	at org.checkerframework.nullaway.dataflow.analysis.ForwardAnalysisImpl.initInitialInputs(ForwardAnalysisImpl.java:351)
    	at org.checkerframework.nullaway.dataflow.analysis.AbstractAnalysis.init(AbstractAnalysis.java:554)
    	at org.checkerframework.nullaway.dataflow.analysis.ForwardAnalysisImpl.performAnalysis(ForwardAnalysisImpl.java:102)
    	at com.uber.nullaway.dataflow.RunOnceForwardAnalysisImpl.performAnalysis(RunOnceForwardAnalysisImpl.java:31)
    	at com.uber.nullaway.dataflow.DataFlow.dataflow(DataFlow.java:163)
    	at com.uber.nullaway.dataflow.DataFlow.resultFor(DataFlow.java:329)
    	at com.uber.nullaway.dataflow.DataFlow.resultForExpr(DataFlow.java:307)
    	at com.uber.nullaway.dataflow.DataFlow.expressionDataflow(DataFlow.java:230)
    	at com.uber.nullaway.dataflow.AccessPathNullnessAnalysis.getNullness(AccessPathNullnessAnalysis.java:119)
    	at com.uber.nullaway.NullAway.nullnessFromDataflow(NullAway.java:2724)
    	at com.uber.nullaway.NullAway.mayBeNullExpr(NullAway.java:2692)
    	at com.uber.nullaway.NullAway.matchDereference(NullAway.java:2752)
    	at com.uber.nullaway.NullAway.matchMemberSelect(NullAway.java:610)
    	at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:541)
[...]
    	at java.base/java.lang.Thread.run(Thread.java:1527)
    Caused by: java.lang.Throwable
    	at org.checkerframework.nullaway.javacutil.BugInCF.<init>(BugInCF.java:26)
    	... 114 more

[cushon]

It looks like this is probably more of a https://github.com/uber/nullaway issue, or perhaps https://github.com/typetools/checker-framework if it's a bug in dataflow and not specific to NullAway.

[sormuras]

Yes, looks like there's something off there:

• Test on JDK 26 and JDK 27 ea uber/NullAway#1525

[sormuras]

@ammbra found this possibly(!) related issue/commit in the OpenJDK 27-ea+16 to 27-ea+17 commit history:

• openjdk/jdk@f6baab7

Which is linked to https://bugs.openjdk.org/browse/JDK-8379550 - reported by @cushon ;-)

[msridhar]

@sormuras if you could share this context on the NullAway issue that'd be great, to make it easier for us to track :-)

[sormuras]

After updating error_prone_core to v2.49.0 in junit-team/junit-framework#5589 the problem goes away but uber/NullAway#1534 does arise.

In the light of that, I close this issue.