Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getSymbols(Predicate, LookupKind) compatibility method #2629

Closed
wants to merge 1 commit into from

Conversation

fawind
Copy link
Contributor

@fawind fawind commented Oct 18, 2021

Add a compatibility helper method for getSymbols(Predicate<Symbol>, LookupKind).

Context:
In gradle-baseline, we maintain our own set of error-prone rules and ran into similar JDK 17 compatibility problems as mentioned in #2330.

However for our custom rules, we also need a compatibility helper for getSymbols(Predicate, LookupKind). For now, we work around this by copying parts of the ErrorProneScope class (PR) but ideally we could reuse the existing helper and wouldn't have to maintain our own fork of this class.

@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@fawind fawind changed the title Add getSymbols(Predicate, LookupKind) compatibility method Add getSymbols(Predicate, LookupKind) compatibility method Oct 18, 2021
cushon
cushon approved these changes Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants