Produce a build error for calls like containsExactly(null) that always lead to NPE.
#5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_814389578
branch
4 times, most recently
from
d98f50f to
50a22db
Compare
…ays lead to NPE. These calls need to be written as `containsExactly((Object) null)` instead. javac produces a warning for such cases, but it's easy to ignore and somewhat difficult to understand. PiperOrigin-RevId: 817159968
copybara-service
bot
force-pushed
the
test_814389578
branch
from
50a22db to
9abc44f
Compare
copybara-service bot
pushed a commit
to google/j2cl
that referenced
this pull request
Oct 13, 2025
…looks for calls like `asList(null)` that always throw NPE. (To produce a list that contains only a null element, the calls needs to be `asList((Foo) null)` (with a cast to the array's _element_ type), not `asList(null)` or `asList((Foo[]) null)` (with a cast to the _array_ type). ([the check](google/error-prone#5263)) PiperOrigin-RevId: 818769295
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Oct 13, 2025
…looks for calls like `asList(null)` that always throw NPE. (To produce a list that contains only a null element, the calls needs to be `asList((Foo) null)` (with a cast to the array's _element_ type), not `asList(null)` or `asList((Foo[]) null)` (with a cast to the _array_ type). ([the check](google/error-prone#5263)) PiperOrigin-RevId: 818740054
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Oct 13, 2025
…looks for calls like `containsExactly(null)` that always throw NPE. (To check for a list that contains only a null element, the calls will soon need to be `containsExactly((Object) null)` (with a cast to the array's _element_ type), not `containsExactly(null)` or `containsExactly((Object[]) null)` (with a cast to the _array_ type).) Also, sidestep other null-varargs fun by using `Collections.singleton` instead of the varargs methods `Arrays.asList` and `Stream.of`.) ([the check](google/error-prone#5263)) PiperOrigin-RevId: 818740054
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
Oct 13, 2025
…looks for calls like `containsExactly(null)` that always throw NPE. (To check for a list that contains only a null element, the calls will soon need to be `containsExactly((Object) null)` (with a cast to the array's _element_ type), not `containsExactly(null)` or `containsExactly((Object[]) null)` (with a cast to the _array_ type).) Also, sidestep other null-varargs fun by using `Collections.singleton` instead of the varargs methods `Arrays.asList` and `Stream.of`.) ([the check](google/error-prone#5263)) PiperOrigin-RevId: 818803000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produce a build error for calls like
containsExactly(null)that always lead to NPE.These calls need to be written as
containsExactly((Object) null)instead.javac produces a warning for such cases, but it's easy to ignore and somewhat difficult to understand.