Fix bad memory leak in the GL backend.#3894
Merged
Merged
Conversation
This leak was introduced in the following PR on April 7. #3775 The guilty party has been contacted and properly admonished for his transgression. This was tested by adding the following code after applyAnimation in gltf_viewer.cpp static int nframes = 0; if (!gpath.empty() && nframes++ > 100) { static int count = 0; printf("reloading %d\n", count++); nframes = 0; app.resourceLoader->asyncCancelLoad(); app.resourceLoader->evictResourceData(); app.viewer->removeAsset(); app.assetLoader->destroyAsset(app.asset); loadAsset(gpath, app); loadResources(gpath, app); }
bejado
approved these changes
May 4, 2021
prideout
changed the title
pixelflinger
approved these changes
May 5, 2021
prideout
added a commit
that referenced
this pull request
May 5, 2021
This leak was introduced in the following PR on April 7. #3775 The guilty party has been contacted and properly admonished for his transgression. This was tested by adding the following code after applyAnimation in gltf_viewer.cpp static int nframes = 0; if (!gpath.empty() && nframes++ > 100) { static int count = 0; printf("reloading %d\n", count++); nframes = 0; app.resourceLoader->asyncCancelLoad(); app.resourceLoader->evictResourceData(); app.viewer->removeAsset(); app.assetLoader->destroyAsset(app.asset); loadAsset(gpath, app); loadResources(gpath, app); }
elisemorysc
pushed a commit
to elisemorysc/filament
that referenced
this pull request
May 5, 2021
This leak was introduced in the following PR on April 7. google#3775 The guilty party has been contacted and properly admonished for his transgression. This was tested by adding the following code after applyAnimation in gltf_viewer.cpp static int nframes = 0; if (!gpath.empty() && nframes++ > 100) { static int count = 0; printf("reloading %d\n", count++); nframes = 0; app.resourceLoader->asyncCancelLoad(); app.resourceLoader->evictResourceData(); app.viewer->removeAsset(); app.assetLoader->destroyAsset(app.asset); loadAsset(gpath, app); loadResources(gpath, app); }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leak was introduced in the following PR on April 7 and was therefore released to the wild in v1.9.20.
#3775
We were creating and allocating low-level VBO handles, but then they got clobbered later when the new BufferObject VBO handles were pushed to the VertexBuffer.
Fixes #3888