External sampler research experimentation #8497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt at an implementation by passing the specific data needed from the application to the material builder. This ensures that by the time the material is getting built on the VK backend, we can create the descriptor set layout.
Adding the platform side code.
- We need to pipe the ext format and the ycbcr to the backend - We need to be able to retreive the sampler when binding the texture when updating the descriptor set - We need to create the sampler based on the info from the DescriptorSetLayoutBinding when creating the descriptor set.
Not sure this is the cleanest way, but we do not have a good way to work around the need to explicitely passing the extra data.
Still lot of things up for review.
No difference for GL no both call the same function.
Forgot it.
The construction of the descriptor set layout requires it.
phoenixxxx
changed the title
Contributor
|
closing because no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for reference and will be broken up into smaller PRs.
This is the explicit method which adds quite a few APIs but is less intrusive, however burdens the caller with createating a 1-1 correspondance between Material and Texture.