webgpu: textures and initial textureview work #8665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridgewaterrobbie
force-pushed
the
ebridgewater/wgpuTextureHandlingBegin
branch
from
d185a51 to
cc22348
Compare
bridgewaterrobbie
changed the title
bridgewaterrobbie
force-pushed
the
ebridgewater/wgpuTextureHandlingBegin
branch
3 times, most recently
from
32af21d to
48801ea
Compare
AndyHovingh
reviewed
Apr 29, 2025
AndyHovingh
reviewed
Apr 29, 2025
bridgewaterrobbie
force-pushed
the
ebridgewater/wgpuTextureHandlingBegin
branch
from
48801ea to
d76ce50
Compare
AndyHovingh
reviewed
Apr 29, 2025
bridgewaterrobbie
force-pushed
the
ebridgewater/wgpuTextureHandlingBegin
branch
from
d76ce50 to
3f43aba
Compare
bridgewaterrobbie
changed the title
jneljneljnel
reviewed
May 5, 2025
| uint32_t width, uint32_t height, uint32_t depth, TextureUsage usage, | ||
| wgpu::Device device) noexcept { | ||
|
|
||
| // First the texture aspect |
Contributor
There was a problem hiding this comment.
Do you mean the aspect for the Texture View? wdym here? Is this a helpful comment?
jneljneljnel
reviewed
May 5, 2025
| // layout index for efficiency. Add guards if wrong. | ||
| entries[index] = std::move(entry); | ||
| } | ||
| // From createTextureR |
Contributor
There was a problem hiding this comment.
I think this comment will get stale very quickly when the swapchain uses it, do we need it?
Contributor
|
@bridgewaterrobbie this can be closed now yes? I think this was merged in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for CreateTexture and TextureView calls that we will support in this first pass.
BUGS=[403532779]