fix use-after-free of the EGL swapchain#9495
Merged
pixelflinger merged 1 commit intomainfrom Dec 8, 2025
Merged
Conversation
PlatformEGLAndroid holds onto the current swapchain in order to use it when beginFrame is called. Usually the swapchain is set just before beginFrame is called. However, that's not the case for standalone views. These are independent of the swapchain and doing "swapchain stuff" for them is nonsensical. So make sure that: 1. PlatfromEGLAndroid doesn't hold onto a dangling pointer when the swapchain is destroyed. And add proper null checks. 2. Don't do the "swapchain stuff" when beginFrame is called in the context of a standalone view. We now reserve frameID 0 for that purpose (meaning the frameid is non sensical for these). We're currently relying on frameID to not wrap-around. At 120 fps, that's about 1 year. This will be addressed in a later PR. FIXES=[462827028, 461399487]
poweifeng
approved these changes
Dec 8, 2025
z3moon
approved these changes
Dec 8, 2025
pixelflinger
added a commit
that referenced
this pull request
Dec 8, 2025
PlatformEGLAndroid holds onto the current swapchain in order to use it when beginFrame is called. Usually the swapchain is set just before beginFrame is called. However, that's not the case for standalone views. These are independent of the swapchain and doing "swapchain stuff" for them is nonsensical. So make sure that: 1. PlatfromEGLAndroid doesn't hold onto a dangling pointer when the swapchain is destroyed. And add proper null checks. 2. Don't do the "swapchain stuff" when beginFrame is called in the context of a standalone view. We now reserve frameID 0 for that purpose (meaning the frameid is non sensical for these). We're currently relying on frameID to not wrap-around. At 120 fps, that's about 1 year. This will be addressed in a later PR. FIXES=[462827028, 461399487]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformEGLAndroid holds onto the current swapchain in order to use it when beginFrame is called. Usually the swapchain is set just before beginFrame is called. However, that's not the case for standalone views. These are independent of the swapchain and doing "swapchain stuff" for them is nonsensical.
So make sure that:
We're currently relying on frameID to not wrap-around. At 120 fps, that's about 1 year. This will be addressed in a later PR.
FIXES=[462827028, 461399487]