Merged
Conversation
pixelflinger
force-pushed
the
ma/better-dispersion
branch
from
6aa35d5 to
50e9d8f
Compare
Collaborator
Author
|
@poweifeng the renderdiff difference is just one pixel and barely visible and only for gles. I think we can accept the new image as master (I just don't know how). |
z3moon
approved these changes
Dec 29, 2025
bejado
approved these changes
Jan 5, 2026
pixelflinger
force-pushed
the
ma/better-dispersion
branch
2 times, most recently
from
d9d8794 to
08c13a8
Compare
- Split the function so that the 3-components loop is more apparent. - Factored out the parts of the computation that don't depend on the index of refraction, so they're only computed once. - Moved the lod-from-roughness computation out of the loop as well. It does depend on the IOR, but so little that it's not worth it. The most important result of this change is that the code is now in good shape if we wanted to change the implementation of dispersion for these cases (for e.g.) : - do the computation in the XYZ space - use more than 3 wavelengths samples - or use a stochastic approach, trading banding for noise RDIFF_BRANCH=ma/better-dispersion
pixelflinger
force-pushed
the
ma/better-dispersion
branch
from
08c13a8 to
945c0cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important result of this change is that the code is now in good shape if we wanted to change the implementation of dispersion for these cases (for e.g.) :