Merged
Conversation
- Add support for vector parameters (float2, float3, float4) in the
parameters file using `{x, y, z}` syntax.
- Allow comments (`#`, `//`) and empty lines in the parameters file.
- Make the end value optional in the parameters file
(defaults to start value).
- Add `--size` / `-S` option to specify viewport dimensions.
- Optimize rendering by pre-filtering active material parameters.
- Remove hardcoded default parameters and silently ignore missing
parameters to support shared configuration files.
- Add documentation for the parameters file format.
pixelflinger
force-pushed
the
ma/dispersion
branch
from
75c6b9b to
ec61d3d
Compare
poweifeng
approved these changes
Jan 5, 2026
| g_clearColor = (uint32_t) std::stoul(arg, nullptr, 16); | ||
| g_clearColor = uint32_t(std::stoul(arg, nullptr, 16)); | ||
| } catch (std::invalid_argument& e) { | ||
| g_clearColor = {}; |
Contributor
There was a problem hiding this comment.
nit: some warning logging here would be helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{x, y, z}syntax.#,//) and empty lines in the parameters file.--size/-Soption to specify viewport dimensions.