Refactor FrameGraph pass API for flexibility#9571
Merged
pixelflinger merged 1 commit intomainfrom Jan 6, 2026
Merged
Conversation
This commit simplifies and unifies the FrameGraph's `addPass` API. Key changes: - The `addPass` method now uses a single, more flexible implementation that handles different lambda signatures for both the setup and execute stages. - The execute lambda can now optionally omit the `DriverApi&` parameter, reducing boilerplate for simple passes. - The `addTrivialSideEffectPass` helper has been removed. Side-effect-only passes can now be created directly with `addPass`
poweifeng
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit simplifies and unifies the FrameGraph's
addPassAPI. Key changes:addPassmethod now uses a single, more flexible implementation that handles different lambda signatures for both the setup and execute stages.DriverApi¶meter, reducing boilerplate for simple passes.addTrivialSideEffectPasshelper has been removed. Side-effect-only passes can now be created directly withaddPass