diffimg: binary tool for comparing images#9668
Merged
Conversation
poweifeng
force-pushed
the
pf/imgdiff-tool
branch
2 times, most recently
from
a2a72e8 to
eb74b90
Compare
This tool uses existing libraries: image, imageio, imageio-lite, imagediff to perform difference comparison for on-disk images. We refactor renderdiff to use this tool instead of using python dependencies.
poweifeng
force-pushed
the
pf/imgdiff-tool
branch
from
eb74b90 to
2af8cf8
Compare
bejado
approved these changes
Feb 6, 2026
| std::string ext = path.getExtension(); | ||
| std::transform(ext.begin(), ext.end(), ext.begin(), ::tolower); | ||
|
|
||
| bool preferLite = (ext == "tif" || ext == "tiff"); |
Member
There was a problem hiding this comment.
What's the benefit of using imageio lite?
Contributor
Author
There was a problem hiding this comment.
Yeah, this can read a bit strange. So I tried to list reasons in the initial commit:
b40530a
Co-authored-by: Ben Doherty <bendoherty@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool uses existing libraries: image, imageio, imageio-lite, imagediff to perform difference comparison for on-disk images.
We refactor renderdiff to use this tool instead of using python dependencies.