Fix framebuffer cache memory leak#9693
Merged
poweifeng merged 2 commits intogoogle:mainfrom Feb 9, 2026
Merged
Conversation
anishmgoyal
force-pushed
the
fixFboCache
branch
from
616c509 to
fce8eb6
Compare
poweifeng
approved these changes
Feb 9, 2026
Once a framebuffer is destroyed, it must be removed from the mapping, and not just marked unused. Same for render passes.
Contributor
Author
|
gonna push a quick update based on the robin map update! |
Now that we updated our dependency, some of the iterator operations are defined in a more stl-compliant way. We can remove some of the messy iterator logic introduced as a workaround.
anishmgoyal
force-pushed
the
fixFboCache
branch
from
7bce11c to
fb5569d
Compare
rafadevai
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a framebuffer is destroyed, it must be removed from the mapping, and not just marked unused. Same for render passes.