Skip to content

VK: Fix validation errors when creating a sampler #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poweifeng merged 2 commits into from
Feb 11, 2026
+7 −0
Merged

VK: Fix validation errors when creating a sampler #9708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da9c9aa
VK: Fix validation errors when creating a sampler
rafadevai Feb 10, 2026
53c7492
Merge branch 'main' into conversion_validation_error
poweifeng Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions filament/backend/src/vulkan/VulkanExternalImageManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ void VulkanExternalImageManager::bindExternallySampledTexture(
// https://registry.khronos.org/vulkan/specs/latest/man/html/VkSamplerCreateInfo.html#VUID-VkSamplerCreateInfo-minFilter-01645
samplerParams.filterMag = SamplerMagFilter::NEAREST;
samplerParams.filterMin = SamplerMinFilter::NEAREST;
// If the sampler has a ycbcrConversion then anisotropic must be disabled and addressModeU,
// addressModeV and addressModeW must be VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE.
// https://docs.vulkan.org/spec/latest/chapters/samplers.html#VUID-VkSamplerCreateInfo-addressModeU-01646
samplerParams.wrapS = SamplerWrapMode::CLAMP_TO_EDGE;
samplerParams.wrapT = SamplerWrapMode::CLAMP_TO_EDGE;
samplerParams.wrapR = SamplerWrapMode::CLAMP_TO_EDGE;
samplerParams.anisotropyLog2 = 0;

VkSampler const sampler = mSamplerCache->getSampler({
.sampler = samplerParams,
Expand Down
Loading