Small fix to allow PlatformEGL to work on non-Android targets.#9724
Merged
Conversation
romainguy
reviewed
Feb 18, 2026
poweifeng
reviewed
Feb 18, 2026
pixelflinger
requested changes
Feb 19, 2026
Collaborator
pixelflinger
left a comment
pixelflinger
left a comment
There was a problem hiding this comment.
let's split this PR. The first part with checking for null is fine. I'm not convinced about including gl_headers, I don't quite understand the problem.
haroonq
changed the title
Contributor
Author
Reverted the change to PlatformEGLHeadless. For context, on line 38, it checks for |
pixelflinger
approved these changes
Feb 20, 2026
poweifeng
approved these changes
Feb 26, 2026
z3moon
approved these changes
Feb 26, 2026
- Include gl_headers.h since it defines BACKEND_OPENGL_VERSION_GL(ES)
depending on which headers are available.
- Don't assume glGetString(GL_EXTENSIONS) returns a non-null value as
null is a possible return value for OpenGL (desktop).
bejado
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't assume glGetString(GL_EXTENSIONS) returns a non-null value as null is a possible return value for OpenGL (desktop).