Request for Bazel rules

[jschaf]

I'd like to use Bazel to generate the Java wrappers for flatbuffers similar to java_proto_library.

Any chance we can open-source the internal BUILD rules? I'm willing to write the CLs if that's good by you all.

[aardappel]

I think that be a great idea (open sourcing the BUILD files).. @stewartmiles what do you think?

[stewartmiles]

@aardappel seems possible though I can imagine some of what we maintain in our internal BUILD files may not work with Bazel and may refer to projects we can't expose. In short it sounds like work, @jschaf (if you're the Googler of the same name) seems like we may need to maintain a couple of BUILD files, one that is open sourced and another that remains internal, you game for it?

[jschaf]

Yep, same username at Google. I'm happy to give it a go. For a high-level plan, I'm thinking: - Add all the Bazel stuff (WORKSPACE, BUILD, etc) via GitHub PRs. - Import into Google making sure to only expose the internal rule.

…

On Tue, Jan 9, 2018 at 11:10 AM, Stewart Miles ***@***.***> wrote: @aardappel <https://github.com/aardappel> seems possible though I can imagine some of what we maintain in our internal BUILD files may not work with Bazel and may refer to projects we can't expose. In short it sounds like work, @jschaf <https://github.com/jschaf> (if you're the Googler of the same name) seems like we may need to maintain a couple of BUILD files, one that is open sourced and another that remains internal, you game for it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4574 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABXcdGn_RLTRoBd59Av7dEavsbEWYVgks5tI7magaJpZM4ROq1q> .

[stewartmiles]

Sounds fair to me, probably worth refactoring our internal BUILD file since it's almost there :)

[jschaf]

The high level plan is to mirror how tensorflow is doing it:

• Deps under //third_party/<dep_name>, e.g. tensorflow/third_party/flatbuffers
• Each third_party dependency defines:
  1. <dep_name>.BUILD - a BUILD rule referenced by new_http_archive or similar command to actually build the dependency.
  2. BUILD - re-exports the build rules from <dep_name>.BUILD to enable referencing rules as //third_party/<dep_name>:target instead of @com_github_<user>_<repo>//:target
  3. build_defs.bzl - Any useful skylark macros go here.

The repos will be defined in third_party/repo.bzl which will be imported by the root WORKSPACE.

[aardappel]

@jschaf note that FlatBuffers does not have any dependencies. It can work with GRPC but does not directly depend on it. It doesn't even use Google Test :)

[jschaf]

Yep, I found out last night, that makes things a lot easier. I ran into some issues with cc_library includes. You mind taking a look at the PR #4608. I'm not quite sure how to fix the error.

[tmandry]

I think this can be closed now?

[aardappel]

Yup, thanks @jschaf !