Python flatbuffers read support

[shaxbee]

Python code generator for flatbuffers reading.

[ghost]

Thanks! Will have a look later.

[rw]

Interesting. I'd like to see much more testing on this. Have you looked at the read tests in the C++ version? Fuzz-testing would be appropriate here.

Keep it up!

[shaxbee]

Sure. I'll be able to do that only after new year though.

On Fri, 12 Dec 2014 15:29 Robert notifications@github.com wrote:

Interesting. I'd like to see much more testing on this. Have you looked at
the read tests in the C++ version? Fuzz-testing would be appropriate here.

Keep it up!

—
Reply to this email directly or view it on GitHub
#110 (comment).

[shaxbee]

@rw: Working on fuzz tests now - they require builder support for tables / scalar fields, I've aligned Python builder interface with C++/Go as seen in 747030d

[stewartmiles]

Just a small thing, we follow the Google C++ style guide
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html

To adhere to this, you'll need to line up the arguments followed by the function definition to the opening parenthesis.

BTW: I tried pasting a formatted version in here but failed :(

[stewartmiles]

   extern bool GeneratePython(const Parser &parser,
                              const std::string &path,
                              const std::string &file_name,
                              const GeneratorOptions &opts);

[stewartmiles]

Why use a tuple rather than declare the members of this class via the init() method? Seems a little bit odd to me at the moment.

I have similar reservations about Struct and Table.

[shaxbee]

Immutability and speed of property access - same trick is being used in collections.namedtuple.
You can find more details about that here: of http://shaxbee.github.io/python-binary-part2-struct-unpack/

[rw]

Please compare with the Python 2/3 port I pushed today: #112. Maybe we can combine these?

[stewartmiles]

Please limit lines to 80 characters

[shaxbee]

Fuzz testing, fixed formatting, added more docstrings. I'll work on builder codegen now.

[shaxbee]

Hello, go ahead and close it, I'll work on struct based read/write and some other perf optimizations once #112 is merged.