C++ Feature: Mutable union getters #8852
Merged
+375
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
c#
c++
typescript
codegen
Collaborator
Author
|
seems like generate_code.py runs differently on windows... |
This reverts commit 45e352b.
jtdavis777
added
the
ready-for-merge
Collaborator
|
Remind me why we need these mutable accessors? The things returned are FlatBuffer buffer pointer types, those should typically never be needed non-const. |
Collaborator
Author
|
This is just matching other patterns found in the c++ generated code. There is a mutable void* accessor and non mutable type based accessors. This data is accessible in this way but both through a convenient accessor. This or is a precursor to my std variant pr |
Collaborator
|
Ah yes, I see that now. LGTM. |
aardappel
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mutable union accessors ahead of a fix for #8761