[Swift] Uses a pointer based stack instead of native array#8891
Merged
mustiikhalil merged 2 commits intogoogle:masterfrom Feb 12, 2026
Merged
[Swift] Uses a pointer based stack instead of native array#8891mustiikhalil merged 2 commits intogoogle:masterfrom
mustiikhalil merged 2 commits intogoogle:masterfrom
Conversation
cfde57e to
3688211
Compare
… array for improved performance Remove custom flags for native arrays when using flexbuffers on Wasm
3688211 to
866521e
Compare
Collaborator
|
Kinda sad their builtin arrays are implemented so badly that doing it custom is that much faster.. |
aardappel
approved these changes
Feb 12, 2026
Collaborator
Author
|
@aardappel they arent completely bad, but the issue is the hand holding they have in terms of their implementations. Thus they gave developers the option to use the RandomAcessCollection, which just an array but you have a bit of power in terms of how to use them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a pointer based stack instead of native array, the performance sometimes struggles when using native arrays thus switching to a custom structure gave the flexbuffer implementation a bit of a speed up. As shown below, twitter encoding became a bit faster, but we still struggle with the bigger chunks like Canada data set.
Stack:
Previous implementation: