Conversation
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
- Coverage 82.02% 82.01% -0.01%
==========================================
Files 63 63
Lines 5112 5110 -2
==========================================
- Hits 4193 4191 -2
Misses 919 919
Continue to review full report at Codecov.
|
flax/optim/base.py
Outdated
There was a problem hiding this comment.
Wouldn't it be easier to move the deprecation warning to some piece of the old Module code that is always triggered when you actually use it? Like the Module constructor? Other codebases might also important the old nn api for simple instance checks and such or other backward compatibility tasks.
There was a problem hiding this comment.
Good point. That's much simpler indeed. /cc @levskaya.
import flaxled to aflax.nndeprecation warning. In order to eliminate this, we now only raise a deprecation warning when instantiating aflax.nn.Moduleinstance, not simply when importingflax.nn.