Skip to content

Release 0.3.2#1055

Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom
avital:0.3.2
Mar 1, 2021
Merged

Release 0.3.2#1055
copybara-service[bot] merged 1 commit intogoogle:masterfrom
avital:0.3.2

Conversation

@avital
Copy link
Contributor

@avital avital commented Mar 1, 2021

  1. In the 0.3.1 release we (I) forgot to update the README for the new version
  2. In the 0.3.1 release, import flax led to a flax.nn deprecation warning. In order to eliminate this, we now only raise a deprecation warning when instantiating a flax.nn.Module instance, not simply when importing flax.nn.
  3. Un-revert accidental changes to CHANGELOG that erased the 0.3.1 changes (f63d210)

@google-cla google-cla bot added the cla: yes label Mar 1, 2021
@codecov-io
Copy link

Codecov Report

Merging #1055 (f8fcbbe) into master (b35b60f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   82.02%   82.01%   -0.01%     
==========================================
  Files          63       63              
  Lines        5112     5110       -2     
==========================================
- Hits         4193     4191       -2     
  Misses        919      919              
Impacted Files Coverage Δ
flax/__init__.py 100.00% <ø> (ø)
flax/nn/base.py 92.46% <ø> (ø)
flax/optim/base.py 82.25% <100.00%> (-0.10%) ⬇️
flax/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35b60f...f8fcbbe. Read the comment docs.

@avital avital requested a review from jheek March 1, 2021 08:14
@avital avital self-assigned this Mar 1, 2021
@avital avital requested a review from levskaya March 1, 2021 08:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to move the deprecation warning to some piece of the old Module code that is always triggered when you actually use it? Like the Module constructor? Other codebases might also important the old nn api for simple instance checks and such or other backward compatibility tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. That's much simpler indeed. /cc @levskaya.

@copybara-service copybara-service bot merged commit c5223d0 into google:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants