Checkpoint fix #1200
Merged
Checkpoint fix #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync upstream changes
Fix bug in the case where job was preempted after the temporary checkpoint was written, but before it was renamed to the final checkpoint name.
jheek
approved these changes
Apr 6, 2021
Member
jheek
left a comment
jheek
left a comment
There was a problem hiding this comment.
I'm surprised this didn't pop up before. Thanks for the fix!
avital
reviewed
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug in the case where job was preempted after the temporary checkpoint was written, but before it was renamed to the final checkpoint name.
Currently, this will result in an "InvalidCheckpointError" being thrown.
Fixes # (issue)
Checklist
checks if that's the case).
discussion (please add a
link).
documentation guidelines.
(No quality testing = no merge!)