Don't wrap user-defined __post_init__ function.#1206
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_366889549
branch
from
90b8eb6 to
12b4138
Compare
To make setup() sound under laziness we removed the ability to "normalize" dataclass attributes from setup(). For those requiring this feature, allow the use of a custom __post_init__ (which of course must call super().__post_init__) by not accidentally breaking it with our automatic method wrapping. PiperOrigin-RevId: 367076810
copybara-service
Bot
force-pushed
the
test_366889549
branch
from
12b4138 to
bc31315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't wrap user-defined post_init function.
To make setup() sound under laziness we removed the ability to "normalize"
dataclass attributes from setup(). For those requiring this feature, allow
the use of a custom post_init (which of course must call super().post_init)
by not accidentally breaking it with our automatic method wrapping.