[flex/linen]: Make rngs type "Optional" to avoid pytype errors.#1293
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 1, 2021
Merged
[flex/linen]: Make rngs type "Optional" to avoid pytype errors.#1293copybara-service[bot] merged 1 commit intomasterfrom
rngs type "Optional" to avoid pytype errors.#1293copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_371429989
branch
from
eac9592 to
37d151f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 65 65
Lines 5310 5310
=======================================
Hits 4371 4371
Misses 939 939
Continue to review full report at Codecov.
|
copybara-service
bot
force-pushed
the
test_371429989
branch
from
37d151f to
c69c6b3
Compare
Setting `rngs` to None in apply() is valid (also the default), but setting it explicitly in a callee site causes pytype errors. PiperOrigin-RevId: 371438792
copybara-service
bot
force-pushed
the
test_371429989
branch
from
c69c6b3 to
0848d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[flex/linen]: Make
rngstype "Optional" to avoid pytype errors.Setting
rngsto None in apply() is valid (also the default), but setting itexplicitly in a callee site causes pytype errors.