Skip to content

Expose merge_param at top level of flax.linen.#1324

Merged
copybara-service[bot] merged 1 commit into
google:masterfrom
n2cholas:merge_param_import
May 19, 2021
Merged

Expose merge_param at top level of flax.linen.#1324
copybara-service[bot] merged 1 commit into
google:masterfrom
n2cholas:merge_param_import

Conversation

@n2cholas

Copy link
Copy Markdown
Contributor

Fixes #1319 to let users access merge_param through flax.linen.merge_param.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@google-cla google-cla Bot added the cla: yes label May 17, 2021
@jheek jheek self-requested a review May 18, 2021 07:46
@jheek

jheek commented May 18, 2021

Copy link
Copy Markdown
Contributor

Hi, the build failed due to a dependency resolution problem with the latest tensorflow release. Could you rebase this PR please?

@n2cholas

Copy link
Copy Markdown
Contributor Author

@jheek I rebased but the run still failed. For some reason I can't see the details of why it failed, all I can see is an "X" with "This check failed".

@codecov-commenter

codecov-commenter commented May 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1324 (bf1c2df) into master (c53c1c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files          65       65           
  Lines        5316     5316           
=======================================
  Hits         4377     4377           
  Misses        939      939           
Impacted Files Coverage Δ
flax/linen/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53c1c5...bf1c2df. Read the comment docs.

@marcvanzee

Copy link
Copy Markdown
Contributor

@jheek I rebased but the run still failed. For some reason I can't see the details of why it failed, all I can see is an "X" with "This check failed".

I think it actually succeeded, but it still shows the previous run that failed.

@copybara-service copybara-service Bot merged commit 276ee00 into google:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: module 'flax.linen' has no attribute 'merge_param'

4 participants