Fix potential race condition in restoring checkpoints.#1335
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_374851562
branch
5 times, most recently
from
e9e3fb3 to
cc7092c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
=======================================
Coverage 82.33% 82.33%
=======================================
Files 65 65
Lines 5316 5316
=======================================
Hits 4377 4377
Misses 939 939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Before this cl, gfile.isdir(ckpt_dir) could return False, b/c ckpt_dir did not exist. And if right after that ckpt_dir was created as directory, gfile.exists(ckpt_path) would return true and we'd try to read ckpt_dir as a checkpoint file, which would fail. PiperOrigin-RevId: 374874617
copybara-service
Bot
force-pushed
the
test_374851562
branch
from
cc7092c to
572f518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix potential race condition in restoring checkpoints.
Before this cl, gfile.isdir(ckpt_dir) could return False, b/c ckpt_dir did not exist.
And if right after that ckpt_dir was created as directory, gfile.exists(ckpt_path) would return true and we'd try to read ckpt_dir as a checkpoint file, which would fail.