Skip to content

Support string annotations for module name #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 16, 2022
Merged

Support string annotations for module name #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flax/linen/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ def _customized_dataclass_transform(cls):
if ('parent' in annotations
and annotations['parent'] != parent_annotation):
raise errors.ReservedModuleAttributeError(annotations)
if 'name' in annotations and annotations['name'] != str:
if 'name' in annotations and annotations['name'] not in ('str', str):
raise errors.ReservedModuleAttributeError(annotations)
# Add `parent` and `name` default fields at end.
# We temporarily modify base class __dataclass_fields__ to force desired
Expand Down