Skip to content

use more efficient softmax in dot product attention.#334

Merged
copybara-service[bot] merged 1 commit intomasterfrom
test_317835753
Jul 3, 2020
Merged

use more efficient softmax in dot product attention.#334
copybara-service[bot] merged 1 commit intomasterfrom
test_317835753

Conversation

@copybara-service
Copy link
Copy Markdown

@copybara-service copybara-service bot commented Jun 23, 2020

use more efficient softmax in dot product attention.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files          34       34           
  Lines        2248     2248           
=======================================
  Hits         1777     1777           
  Misses        471      471           
Impacted Files Coverage Δ
flax/nn/attention.py 78.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b566e59...9551b66. Read the comment docs.

@avital
Copy link
Copy Markdown
Contributor

avital commented Jun 23, 2020

@levskaya should this be closed in favor of #333?

cc @jekbradbury

@levskaya
Copy link
Copy Markdown
Collaborator

#333 is from an older change, so this is the PR to add.

@copybara-service copybara-service bot closed this Jul 3, 2020
@copybara-service copybara-service bot merged commit 7fcc7f6 into master Jul 3, 2020
@copybara-service copybara-service bot deleted the test_317835753 branch July 3, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants