fix pooling ops with explicit padding#362
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Aug 11, 2020
Merged
fix pooling ops with explicit padding#362copybara-service[bot] merged 1 commit intogoogle:masterfrom
copybara-service[bot] merged 1 commit intogoogle:masterfrom
Conversation
Collaborator
Author
|
Note we need to wait for JAX to cut a new release to test and use this modification. |
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 78.87% 78.92% +0.04%
==========================================
Files 34 34
Lines 2258 2263 +5
==========================================
+ Hits 1781 1786 +5
Misses 477 477
Continue to review full report at Codecov.
|
Collaborator
Author
|
Ok we can finally merge this! |
avital
approved these changes
Aug 11, 2020
avital
referenced
this pull request
in rolandgvc/flaxvision
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous max_pool and avg_pool didn't work with explicit (e.g.
((1,1),(1,1))padding specs) padding for the reduce window.fixes #356