Skip to content

fix pooling ops with explicit padding#362

Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom
levskaya:poolingfix
Aug 11, 2020
Merged

fix pooling ops with explicit padding#362
copybara-service[bot] merged 1 commit intogoogle:masterfrom
levskaya:poolingfix

Conversation

@levskaya
Copy link
Collaborator

previous max_pool and avg_pool didn't work with explicit (e.g. ((1,1),(1,1)) padding specs) padding for the reduce window.
fixes #356

@levskaya
Copy link
Collaborator Author

Note we need to wait for JAX to cut a new release to test and use this modification.

@codecov-commenter
Copy link

Codecov Report

Merging #362 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   78.87%   78.92%   +0.04%     
==========================================
  Files          34       34              
  Lines        2258     2263       +5     
==========================================
+ Hits         1781     1786       +5     
  Misses        477      477              
Impacted Files Coverage Δ
flax/nn/pooling.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b58fc4...18a9ae5. Read the comment docs.

@levskaya levskaya requested a review from avital August 11, 2020 04:46
@levskaya
Copy link
Collaborator Author

Ok we can finally merge this!

@copybara-service copybara-service bot merged commit 10491c2 into google:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pooling: passing "sequence of n (low, high) integer pairs" resulting in TypeError

4 participants