-
Notifications
You must be signed in to change notification settings - Fork 772
Add .style.yapf config that matches the Google internal style guide. #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Unfortunately the Google internal formating is different from PEP8 (column limit 79 -> 80 and indent width 4 -> 2, a few things around when and how to split lines). YAPFs own style matches this. YAPF will automatically pick up the config when run anywhere inside the repository.
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 34 34
Lines 2256 2256
=======================================
Hits 1777 1777
Misses 479 479 Continue to review full report at Codecov.
|
|
I think this is great! A few questions:
|
We probably want 3 things:
|
|
Wouldn't we want to make sure all commits adhere to the same style guide? That way blame always works because you don't catch other people just reformatting a file that they are editing. |
Unfortunately the Google internal formatting is different from PEP8
(column limit 79 -> 80 and indent width 4 -> 2, a few things around when
and how to split lines). YAPFs own style matches this but is not the default.
YAPF will automatically pick up the config when run anywhere inside the
repository.