Skip to content

harmonized scan#425

Merged
copybara-service[bot] merged 3 commits into
google:masterfrom
jheek:harmonized-scan
Aug 26, 2020
Merged

harmonized scan#425
copybara-service[bot] merged 3 commits into
google:masterfrom
jheek:harmonized-scan

Conversation

@jheek
Copy link
Copy Markdown
Contributor

@jheek jheek commented Aug 24, 2020

No description provided.

@jheek jheek requested a review from levskaya August 24, 2020 11:58
@google-cla google-cla Bot added the cla: yes label Aug 24, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #425 into master will increase coverage by 0.43%.
The diff coverage is 93.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   72.61%   73.04%   +0.43%     
==========================================
  Files          53       53              
  Lines        3918     3881      -37     
==========================================
- Hits         2845     2835      -10     
+ Misses       1073     1046      -27     
Impacted Files Coverage Δ
flax/core/lift.py 70.75% <90.47%> (-2.23%) ⬇️
flax/core/unified_transforms.py 95.31% <94.54%> (+95.31%) ⬆️
flax/linen/__init__.py 100.00% <100.00%> (ø)
flax/linen/transforms.py 92.85% <100.00%> (+4.05%) ⬆️
flax/core/scope.py 81.09% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14883b0...2d0bdb6. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Another PR went in earlier that made merge conflicts, I've already rebased in this change onto master in a new branch, would it be ok for me to push that instead of this?

@jheek
Copy link
Copy Markdown
Contributor Author

jheek commented Aug 25, 2020

Oops, Didn't see your comment so I rebased this branch already

@levskaya levskaya added cla: no and removed cla: yes labels Aug 26, 2020
@google-cla google-cla Bot added cla: yes and removed cla: no labels Aug 26, 2020
@copybara-service copybara-service Bot merged commit 9b84632 into google:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants