Rewrites MNIST example in Linen API#434
Merged
Merged
Conversation
Contributor
|
Cool! I'll take a look. (looks like there's a failing test?) |
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 73.64% 73.64%
=======================================
Files 54 54
Lines 3977 3977
=======================================
Hits 2929 2929
Misses 1048 1048 Continue to review full report at Codecov.
|
Contributor
Author
|
Tests are passing now. |
avital
approved these changes
Aug 28, 2020
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example is added to the directory
linen_examples. Here's a side-by-side diff: https://github.com/google/flax/compare/master..marcvanzee:mnist