Fix scan broadcast issue#474
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Sep 18, 2020
Merged
Conversation
broadcast variables were re-computed during init in each iterations causing excessive slow down.
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 74.53% 74.31% -0.23%
==========================================
Files 54 54
Lines 3955 3971 +16
==========================================
+ Hits 2948 2951 +3
- Misses 1007 1020 +13
Continue to review full report at Codecov.
|
levskaya
approved these changes
Sep 18, 2020
Collaborator
levskaya
left a comment
levskaya
left a comment
There was a problem hiding this comment.
looks great, thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broadcast variables were re-computed during init in each iterations causing excessive slow down.