Introduce manual_type: ManualAxisType parameter on ShapedArray to track varying/unreduced/reduced and remove vma: frozenset parameter.#5339
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 18, 2026
Conversation
copybara-service
bot
force-pushed
the
test_881114175
branch
from
a2c4f50 to
d38f20a
Compare
copybara-service
bot
changed the title
manual_type: ManualAxisType parameter on ShapedArray to track varying/unreduced/reduced and remove vma: frozenset parameter.
copybara-service
bot
force-pushed
the
test_881114175
branch
4 times, most recently
from
8f7dd57 to
affb2d6
Compare
…rack varying/unreduced/reduced and remove `vma: frozenset` parameter. `aval.vma` will still exist as a property for backwards compatibility but `aval.manual_type.varying` is it's equivalent. **Why do this?** Currently, unreduced/reduced on PartitionSpec talk about both Explicit/Manual axes but this makes the implementation and mental model way too complex. So instead, `ManualType` will track all manual stuff like varying, unreduced and reduced and `PartitionSpec` will only talk about explicit sharded, unreduced and reduced. PiperOrigin-RevId: 885334667
copybara-service
bot
force-pushed
the
test_881114175
branch
from
affb2d6 to
4ba66fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
manual_type: ManualAxisTypeparameter on ShapedArray to track varying/unreduced/reduced and removevma: frozensetparameter.aval.vmawill still exist as a property for backwards compatibility butaval.manual_type.varyingis it's equivalent.Why do this?
Currently, unreduced/reduced on PartitionSpec talk about both Explicit/Manual axes but this makes the implementation and mental model way too complex.
So instead,
ManualTypewill track all manual stuff like varying, unreduced and reduced andPartitionSpecwill only talk about explicit sharded, unreduced and reduced.