Port Jax AI stack minigpt example#5405
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vfdev-5
reviewed
Apr 10, 2026
Collaborator
Author
|
Actually, it seems we need to do a little more to make this work with the current NNX. Currently getting some sharding errors. Will debug. |
Collaborator
Author
|
Sharding issues resolved. Have to wait until I have access to multiple gpus to run the full notebook though. |
Collaborator
Author
|
I also exposed the |
12 tasks
Collaborator
|
Looks good but there are some merge issues. |
cgarciae
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR copies the Jax AI stack example https://docs.jaxstack.ai/en/latest/JAX_for_LLM_pretraining.html to the flax examples directory unchanged. The nnx apis used still seem to be appropriate, so no adjustments are required.