Deprecate Variable hooks in favor of custom Variable types.#5415
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 21, 2026
Merged
Deprecate Variable hooks in favor of custom Variable types.#5415copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_897659221
branch
7 times, most recently
from
330cf03 to
87f3149
Compare
This change adds DeprecationWarnings when Variable hooks (on_get_value, on_set_value, etc.) are used. The recommended approach is now to create a custom Variable subclass and overload methods like `get_value` and `set_value`. The summary test has been updated to reflect this new pattern. PiperOrigin-RevId: 903324071
copybara-service
Bot
force-pushed
the
test_897659221
branch
from
87f3149 to
a13993f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate Variable hooks in favor of custom Variable types.
This change adds DeprecationWarnings when Variable hooks (on_get_value, on_set_value, etc.) are used. The recommended approach is now to create a custom Variable subclass and overload methods like
get_valueandset_value. The summary test has been updated to reflect this new pattern.