Skip to content

Added kwargs to call to pass kwargs to basemodule in nnx.LoRA#5421

Merged
copybara-service[bot] merged 1 commit intomainfrom
5412-add-basemod-kwargs-to-lora
Apr 17, 2026
Merged

Added kwargs to call to pass kwargs to basemodule in nnx.LoRA#5421
copybara-service[bot] merged 1 commit intomainfrom
5412-add-basemod-kwargs-to-lora

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Apr 15, 2026

Fixes #5412

What does this PR do?

Fixes # (issue)

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other checks if that's the case).
  • This change is discussed in a Github issue/discussion (please add a link).
  • The documentation and docstrings adhere to the documentation guidelines.
  • This change includes necessary high-coverage tests. (No quality testing = no merge!)

@vfdev-5 vfdev-5 marked this pull request as ready for review April 16, 2026 07:48
@copybara-service copybara-service Bot merged commit d8ef528 into main Apr 17, 2026
23 of 24 checks passed
@copybara-service copybara-service Bot deleted the 5412-add-basemod-kwargs-to-lora branch April 17, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nnx.LoRA.__call__ doesn't forward **kwargs to base_module, breaks models with parameterized linear layers

3 participants