Lint (deprecated) flax.nn.base (NN base modules for JAX)#681
Merged
Conversation
8bitmp3
changed the title
jheek
suggested changes
Dec 2, 2020
Contributor
jheek
left a comment
jheek
left a comment
There was a problem hiding this comment.
Thanks, I just found one newly introduced typo
8bitmp3
commented
Dec 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 80.66% 80.67%
=======================================
Files 56 56
Lines 4267 4269 +2
=======================================
+ Hits 3442 3444 +2
Misses 825 825
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Flax team, I was just studying https://flax.readthedocs.io/en/latest/flax.nn.html?highlight=initi_by_shape#flax.nn.Module.init_by_shape and decided to lint
flax.nn.baseto improve the docs. Also, one of the examples isn't currently rendering well, so I made a quick fix (Example::):Can you let me know if there's a general convention for writing "Module" (a "thing", not an API, such as
Module)? I noticed, the API docs use both "module" and "Module".Cheers 👍