Skip to content

Add some explanation to sync_batch_stats#871

Merged
copybara-service[bot] merged 1 commit intomasterfrom
marcvanzee-patch-1
Jan 25, 2021
Merged

Add some explanation to sync_batch_stats#871
copybara-service[bot] merged 1 commit intomasterfrom
marcvanzee-patch-1

Conversation

@marcvanzee
Copy link
Copy Markdown
Contributor

The x argument was unclear to a user so it may be useful to explain it in a comment.

@google-cla google-cla bot added the cla: yes label Jan 18, 2021
@marcvanzee marcvanzee requested a review from jheek January 18, 2021 14:57
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jan 25, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@marcvanzee marcvanzee reopened this Jan 25, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 25, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 25, 2021

Codecov Report

Merging #871 (f4d234b) into master (7cdfcaf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          55       55           
  Lines        4389     4389           
=======================================
  Hits         3548     3548           
  Misses        841      841           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdfcaf...f4d234b. Read the comment docs.

@copybara-service copybara-service bot merged commit e533f66 into master Jan 25, 2021
@copybara-service copybara-service bot deleted the marcvanzee-patch-1 branch January 25, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants