Zalando Sans SemiExpanded: Version 1.800 added #10344
Merged
Conversation
Taken from the upstream repo https://github.com/zalando/sans at commit zalando/sans@4e44d08.
emmamarichal
added
the
III Expand glyphset
Closed
Contributor
FontSpector reportfontspector version: 1.6.0 Check results[18] ofl/zalandosanssemiexpanded/ZalandoSansSemiExpanded[wght].ttf🔥 FAIL Combined length of family and style must not exceed 32 characters. (name/family_and_style_max_length)
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Check family name for GF Guide compliance. (googlefonts/family_name_compliance)
🔥 FAIL Check a font's STAT table contains compulsory Axis Values. (googlefonts/STAT/compulsory_axis_values)
[code: bad-axis-values]
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * nl_Latn (Dutch) |
| The following auxiliary characters are missing from the font: IJ | |
| The following auxiliary characters are missing from the font: ij | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| Shaper didn't attach tildecomb to M when shaping the text 'M̃' | |
| Shaper didn't attach tildecomb to m when shaping the text 'm̃' | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ | |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: ĕ | * cy_Latn (Welsh) |
| * es_Latn (Spanish) | |
| * hu_Latn (Hungarian) | |
| * pt_Latn (Portuguese) | |
| * sk_Latn (Slovak) | |
| * tr_Latn (Turkish) | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
-
⚠️ WARN Missing separator glyph U+2028 [code: missing-separator-glyphs] -
⚠️ WARN Missing separator glyph U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
ị̀
-
ị̂
-
ị̃
-
ị̄
-
ị́
-
į̀
-
į̂
-
į̃
-
į̄
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
ị̋
-
ị̒
-
ị̇
-
ị̆
-
ị̊
-
ị̉
-
ị̈
-
ị̌
-
į̋
... and 6 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 623 but it should be 622 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Zalando Sans SemiExpanded" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| ZalandoSansSemiExpanded[wght].ttf | |
|---|---|
| Dehinted Size | 148772 |
| Hinted Size | 148796 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.800 [code: version-not-detected]
[18] ofl/zalandosanssemiexpanded/ZalandoSansSemiExpanded-Italic[wght].ttf
🔥 FAIL Combined length of family and style must not exceed 32 characters. (name/family_and_style_max_length)
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded ExtraLight Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID ExtraLight Italic exceeds 32 characterss (11 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded Light Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID Light Italic exceeds 32 characterss (6 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded Medium Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID Medium Italic exceeds 32 characterss (7 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded SemiBold Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID SemiBold Italic exceeds 32 characterss (9 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded Bold Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID Bold Italic exceeds 32 characterss (5 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded ExtraBold Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID ExtraBold Italic exceeds 32 characterss (10 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
- 🔥 FAIL Variable font instance name 'Zalando Sans SemiExpanded Black Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID Black Italic exceeds 32 characterss (6 characters too long).
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
⚠️ WARN Name ID 6 'PostScript Name' exceeds 27 characters (3 characters too long). This has been found to cause problems with PostScript printers, especially on Mac platforms. [code: nameid6-too-long]
🔥 FAIL Check family name for GF Guide compliance. (googlefonts/family_name_compliance)
- 🔥 FAIL "Zalando Sans SemiExpanded" is a CamelCased name. To solve this, simply use spaces instead in the font name. [code: camelcase]
🔥 FAIL Check a font's STAT table contains compulsory Axis Values. (googlefonts/STAT/compulsory_axis_values)
- 🔥 FAIL Compulsory STAT Axis Values are incorrect:
| Name | Axis | Current Value | Expected Value | Current Flags | Expected Flags | Current Linked Value | Expected Linked Value |
|---|---|---|---|---|---|---|---|
| SemiExpanded | wdth | N/A | 112.5 | N/A | 0 | N/A | N/A |
| Black | wght | 900 | 900 | 0 | 0 | N/A | N/A |
| Bold | wght | 700 | 700 | 0 | 0 | N/A | N/A |
| ExtraBold | wght | 800 | 800 | 0 | 0 | N/A | N/A |
| ExtraLight | wght | 200 | 200 | 0 | 0 | N/A | N/A |
| Light | wght | 300 | 300 | 0 | 0 | N/A | N/A |
| Medium | wght | 500 | 500 | 0 | 0 | N/A | N/A |
| Regular | wght | 400 | 400 | 2 | 2 | 700 | 700 |
| SemiBold | wght | 600 | 600 | 0 | 0 | N/A | N/A |
[code: bad-axis-values]
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- tcaron (U+0165): found 4, expected one of: [2, 3, 6]
- one.ss02 (unencoded): found 3, expected one of: [1, 2] [code: contour-count]
⚠️ WARN Are there caret positions declared for every ligature? (ligature_carets)
⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- Q.BRACKET.varAlt01
- cent.BRACKET.varAlt01
- dollar.BRACKET.varAlt01 [code: unreachable-glyphs]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ | |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: ĕ | * cy_Latn (Welsh) |
| * es_Latn (Spanish) | |
| * hu_Latn (Hungarian) | |
| * pt_Latn (Portuguese) | |
| * sk_Latn (Slovak) | |
| * tr_Latn (Turkish) | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| Shaper didn't attach tildecomb to M when shaping the text 'M̃' | |
| Shaper didn't attach tildecomb to m when shaping the text 'm̃' | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * nl_Latn (Dutch) |
| The following auxiliary characters are missing from the font: IJ | |
| The following auxiliary characters are missing from the font: ij |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
-
⚠️ WARN Missing separator glyph U+2028 [code: missing-separator-glyphs] -
⚠️ WARN Missing separator glyph U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̃
-
į̄
-
į̀
-
į̂
-
į̌
-
į́
-
ị̃
-
ị̄
-
ị̀
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̋
-
į̈
-
į̒
-
į̉
-
į̊
-
į̆
-
į̇
-
ị̋
-
ị̈
... and 6 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 625 but it should be 624 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Zalando Sans SemiExpanded" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| ZalandoSansSemiExpanded-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 153328 |
| Hinted Size | 153352 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.800 [code: version-not-detected]
[1] ofl/zalandosanssemiexpanded/article/ARTICLE.en_us.html
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/zalando/sans [code: url-found]
[2] ofl/zalandosanssemiexpanded/METADATA.pb
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (googlefonts/metadata/designer_profiles)
⚠️ WARN Designer jakobekelund still does not have an avatar image. Please provide one. [code: missing-avatar]
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[4] ofl/zalandosanssemiexpanded
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Aleut, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̂ (U+0302) [code: missing-subsetted]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/zalandosanssemiexpanded/ZalandoSansSemiExpanded-Italic[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, tifinagh, coptic, math
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, syriac, todhri, duployan, hebrew, coptic, tai-le, canadian-aboriginal, math, tifinagh, malayalam
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 62 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
⚠️ WARN ofl/zalandosanssemiexpanded/ZalandoSansSemiExpanded[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, tifinagh, coptic, math
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, syriac, todhri, duployan, hebrew, coptic, tai-le, canadian-aboriginal, math, tifinagh, malayalam
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 62 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
- ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.13% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-ital: 2 [code: summary]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 16 | 25 | 16 | 266 | 65 |
| 4% | 7% | 4% | 71% | 17% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from the upstream repo https://github.com/zalando/sans at commit zalando/sans@4e44d08.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS