3D and 2D/1D array texture support on the Vulkan side#1097
Merged
qining merged 2 commits intogoogle:masterfrom Sep 29, 2017
Merged
3D and 2D/1D array texture support on the Vulkan side#1097qining merged 2 commits intogoogle:masterfrom
qining merged 2 commits intogoogle:masterfrom
Conversation
ben-clayton
reviewed
Sep 13, 2017
| for levelIndex := range levels { | ||
| imageLevel := imageLayer.Levels.Get(uint32(levelIndex)) | ||
| img := imageLevel.imageInfo(ctx, s, format) | ||
| if img == nil { |
Contributor
There was a problem hiding this comment.
In GLES we've made an effort to show partially populated textures. It's annoying to only see the image if all levels / layers are populated with data.
Contributor
Author
There was a problem hiding this comment.
4334638 changes all the early returns to continue.
qining
force-pushed
the
texture-array-3d
branch
from
a7429a8 to
4334638
Compare
ben-clayton
approved these changes
Sep 21, 2017
qining
force-pushed
the
texture-array-3d
branch
from
4334638 to
f9db3e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.